rdsr commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268157817
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/SerializationProxies.java
##########
@@ -35,10 +35,10 @@
/**
* Constructor for Java serialization.
*/
- public ConstantExpressionProxy() {
+ ConstantExpressionProxy() {
}
- public ConstantExpressionProxy(boolean trueOrFalse) {
+ ConstantExpressionProxy(boolean trueOrFalse) {
Review comment:
seems like parameter names can have the same name as the field for the
constructor. Would it make sense to keep this consistent with across
constructors and method names? [e.g for the case I commented to above]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
