mccheah commented on issue #143: Applies the Baseline plugin for iceberg-api only. URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-475749504 > I usually prefer line breaks at 100 characters. This uses 120? Do we want to go with that? Interestingly, Google Style Guide wants the column limit to be 100 characters: https://google.github.io/styleguide/javaguide.html#s4.4-column-limit But Baseline wants 120: https://github.com/palantir/gradle-baseline/blob/develop/docs/java-style-guide/readme.md#column-limit-120. I've always found in my coding that 100 characters is far too short, even for Scala (when building on Spark), much less so for Java which is more verbose. I'd be a vote for the 120 character per line limit, but open to changing if the community builds consensus on shorter lines. > One more thing: I don't see a lot of changes to method parameter lists. What is the convention for those? I believe the convention I've always seen when using Baseline is this: ``` public Type myMethod( int param1, int param2, ... ``` So, each parameter on its own line, with 4 space indent from the visibility modifier keyword (`public` in this example. Also, it would be 8 spaces in projects that use 4 spaces as a base for indentation.). But, notably, Baseline checkstyle does _not_ enforce a hard rule on this. I did some brief searching on Google and Checkstyle doesn't have a built-in rule for this, so we'd have to write one ourselves. Sounds a bit involved. What do you think we should do here to proceed @rdblue?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
