xiao-chen edited a comment on issue #142: Update Tasks to retry at least once, log timeouts. URL: https://github.com/apache/incubator-iceberg/pull/142#issuecomment-476057486 Code change LGTM (non-binding), thanks for the PR. ~~I understand this will make sure tasks retry at least once, logging improvement also looks nice. But I don't understand what's the underlying problem that the 1-retry aims to solve, could you explain a bit? (Why retry once will help long-running commits make progress - won't they still be possible to timeout after the first retry?)~~ (edit: I was fortunate to have this explained to me offline by Ryan. The reason for the retry is that retries are relatively cheap while the initial commit is expensive.) Separate but just a few lines down, we could `break` out of the for loop after `matchedRetryException = true;` Happy to throw a different PR if you prefer 😃
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
