xabriel commented on issue #143: Applies the Baseline plugin for iceberg-api only. URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476759906 > The main style setup I changed in the IDEA project were license headers, indentation numbers, and import ordering (static vs. non-static). I think we'll have to unfortunately catch the other deviations we made on a case by case basis moving forward. Not sure I follow. I work on other projects were the equivalent to `checkstyle.xml` is part of the Maven build, and thus the build will fail if the rules set is not abided by. Here is an example from a Maven Scala project I work on: ```xml <!-- Scala style checking configuration --> <plugin> <groupId>org.scalastyle</groupId> <artifactId>scalastyle-maven-plugin</artifactId> <version>${scalastyle-maven-plugin.version}</version> <configuration> <verbose>false</verbose> <failOnViolation>true</failOnViolation> <includeTestSourceDirectory>true</includeTestSourceDirectory> <failOnWarning>false</failOnWarning> <sourceDirectory>${basedir}/src/main/scala</sourceDirectory> <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory> <configLocation>${basedir}/../scalastyle-config.xml</configLocation> <outputFile>${basedir}/target/scalastyle-output.xml</outputFile> <inputEncoding>${project.build.sourceEncoding}</inputEncoding> </configuration> <executions> <execution> <id>scalastyle</id> <phase>validate</phase> <goals> <goal>check</goal> </goals> </execution> </executions> </plugin> ``` Are we saying that a similar integration is not possible with Gradle + Baseline?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
