rdblue commented on issue #139: ORC support integration for Spark 2.4.0 URL: https://github.com/apache/incubator-iceberg/pull/139#issuecomment-478795482 @edgarRd, thanks for working on this! Overall, I think it looks like a great start toward ORC support, but I'd like to add ORC support back a little more carefully this time. Last time, we added ORC support assuming that the remaining problems with it would be fixed rather quickly. Because we haven't seen those fixes, I'd prefer not to expose the write support through Spark (read support is fine). I suggested a way to test this code that doesn't add it to the write path. We can add it to the write path when it can make the same guarantees as the other formats.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
