rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272015504
##########
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##########
@@ -119,17 +119,19 @@ public ManifestGroup select(String... columns) {
manifest.addedFilesCount() + manifest.existingFilesCount() > 0);
}
- Iterable<Iterable<ManifestEntry>> readers = Iterables.transform(
+ Iterable<CloseableIterable<ManifestEntry>> readers = Iterables.transform(
matchingManifests,
manifest -> {
ManifestReader reader =
ManifestReader.read(ops.io().newInputFile(manifest.path()));
FilteredManifest filtered =
reader.filterRows(dataFilter).select(columns);
toClose.add(reader);
Review comment:
This seems redundant, can we also get rid of the `toClose` field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
