rdblue commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272257093
##########
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##########
@@ -53,8 +54,18 @@ public void close() {
};
}
- static <E> CloseableIterable<E> combine(Iterable<E> iterable,
Iterable<Closeable> closeables) {
- return new CloseableGroup.ClosingIterable<>(iterable, closeables);
+ static <E> CloseableIterable<E> combine(Iterable<E> iterable, Closeable
closeable) {
Review comment:
Wrap takes a CloseableIterable and a function to transform the iterable
itself, like bin packing. Combine takes an iterable and associates it with
something to close. I think that `wrap` could be implemented using `combine`
instead. I'll update this and remove `wrap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
