rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272660868
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##########
@@ -293,4 +309,59 @@ public void testMergeAppend() throws Exception {
Assert.assertEquals("Current snapshot should contain 1 merged manifest",
1, metadata.currentSnapshot().manifests().size());
}
+
+ @Test
+ public void testRenameFailures() throws Exception {
+ Assert.assertTrue("Should create v1 metadata",
+ version(1).exists() && version(1).isFile());
+ Assert.assertFalse("Should not create v2 or newer versions",
+ version(2).exists());
+ assertTrue(table instanceof BaseTable);
+ final BaseTable bt = (BaseTable) table;
Review comment:
It would be better to use a longer variable name, like `base`. `b` doesn't
clearly mean "base" later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
