rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r276760622
##########
File path: core/src/main/java/org/apache/iceberg/util/BinPacking.java
##########
@@ -135,7 +135,7 @@ public boolean hasNext() {
return ImmutableList.copyOf(bins.removeFirst().items());
}
- private Bin removeLargestBin(LinkedList<Bin> bins) {
+ private Bin removeLargestBin() {
Review comment:
Should this have been `static` instead of using the instance variable `bins`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
