rdblue commented on a change in pull request #165: Adding the catalog interface to allow iceberg to handle top level catalog operations. URL: https://github.com/apache/incubator-iceberg/pull/165#discussion_r277044793
########## File path: api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +/** + * Identifies a table in iceberg catalog + */ +public class TableIdentifier { + private final NamespaceIdentifier namespaceIdentifier; + private final String tableName; + + public TableIdentifier(NamespaceIdentifier namespaceIdentifier, String tableName) { + if (namespaceIdentifier == null) { + throw new IllegalArgumentException("namespaceIdentifier can not be null"); + } + + if (tableName == null || tableName.isEmpty()) { + throw new IllegalArgumentException("tableName can not be null"); + } + + this.namespaceIdentifier = namespaceIdentifier; + this.tableName = tableName; + } + + public NamespaceIdentifier schemaNameIdentifier() { Review comment: Should be `namespace`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
