rdblue commented on a change in pull request #172: Properly serialize key
metadata in GenericDataFile.
URL: https://github.com/apache/incubator-iceberg/pull/172#discussion_r280115806
##########
File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
##########
@@ -439,4 +442,29 @@ public String toString() {
}
return null;
}
+
+ private void writeObject(ObjectOutputStream output) throws IOException {
Review comment:
This looks correct to me, but I'm wondering if we should serialize to a
`byte[]` in Avro's binary format. That would cut down on the custom
serialization code. Probably not worth doing right now, but we should keep it
in mind for later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
