rdsr commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r280781457
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -34,36 +38,39 @@
/**
* Create a file appender for ORC.
*/
-public class OrcFileAppender implements FileAppender<VectorizedRowBatch> {
- private final Writer writer;
+class OrcFileAppender<D> implements FileAppender<D> {
+ private final static int BATCH_SIZE = 1024;
Review comment:
Default batch size is already a public property
as part of
`org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch#DEFAULT_SIZE` . Also
see below comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
