TGooch44 commented on a change in pull request #205: Adding
InclusiveManifestEvaluator and ResidualEvaluator
URL: https://github.com/apache/incubator-iceberg/pull/205#discussion_r290993311
##########
File path: python/iceberg/api/expressions/strict_metrics_evaluator.py
##########
@@ -15,27 +15,31 @@
# specific language governing permissions and limitations
# under the License.
+import threading
+
from .expressions import Expressions, ExpressionVisitors
from ..expressions.binder import Binder
from ..types import Conversions
class StrictMetricsEvaluator(object):
+ def visitor(self):
+ if not hasattr(self.thread_local_data, "visitors"):
+ self.thread_local_data.visitors =
StrictMetricsEvaluator.MetricsEvalVisitor(self.expr,
+
self.schema,
Review comment:
I'll clean this up in a future PR, I had refactored and didn't line the
indent back up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
