rdsr commented on a change in pull request #206: Add option to load column
stats with data files.
URL: https://github.com/apache/incubator-iceberg/pull/206#discussion_r291279699
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -57,7 +57,11 @@
private static final Logger LOG = LoggerFactory.getLogger(TableScan.class);
private static final SimpleDateFormat DATE_FORMAT = new
SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS");
- private static final List<String> SNAPSHOT_COLUMNS = ImmutableList.of(
+ private static final List<String> SCAN_COLUMNS = ImmutableList.of(
+ "snapshot_id", "file_path", "file_ordinal", "file_format",
"block_size_in_bytes",
+ "file_size_in_bytes", "record_count", "partition"
+ );
+ private static final List<String> SCAN_WITH_STATS_COLUMNS = ImmutableList.of(
Review comment:
Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS
e.g like so
`SCAN_WITHSTATS_COLUMNS =
ImmutableList.<String>builder().addAll(SCAN_COLUMNS).add("value_counts",....).build()`
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
