rdblue commented on a change in pull request #200: Add SnapshotProducer that 
can rewrite manifests
URL: https://github.com/apache/incubator-iceberg/pull/200#discussion_r291366783
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/Table.java
 ##########
 @@ -136,6 +136,14 @@ default AppendFiles newFastAppend() {
    */
   RewriteFiles newRewrite();
 
+  /**
+   * Create a new {@link RewriteManifests rewrite manifests API} to replace 
manifests for this
+   * table and commit.
+   *
+   * @return a new {@link RewriteManifests}
+   */
+  RewriteManifests newRewriteManifests();
 
 Review comment:
   Can we change this to just `rewriteManifests` and use the verb?
   
   I know this matches `newRewrite`, but that rewrite is applying rewrite 
changes, not actually doing the rewrite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to