rdblue commented on a change in pull request #199: ORC metrics and
listPartition support
URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291774284
##########
File path: orc/src/main/java/org/apache/iceberg/orc/TypeConversion.java
##########
@@ -159,21 +154,21 @@ Type convertOrcToType(TypeDescription schema,
ColumnIdMap columnIds) {
for (int c=0; c < fieldNames.size(); ++c) {
String name = fieldNames.get(c);
TypeDescription type = fieldTypes.get(c);
- fields.add(Types.NestedField.optional(columnIds.get(type), name,
- convertOrcToType(type, columnIds)));
+ fields.add(Types.NestedField.optional(type.getId(), name,
Review comment:
Did ORC add field IDs? Why wasn't `getId` used before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
