rdblue commented on a change in pull request #198: [Baseline] Apply Baseline to
iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r291819949
##########
File path: data/src/test/java/org/apache/iceberg/TestSplitScan.java
##########
@@ -60,7 +79,7 @@ public TestSplitScan(String format) {
}
@Before
- public void setup() throws IOException {
+ public void before() throws IOException {
Review comment:
What rule required this change? I usually like to have descriptive names for
`@Before` and `@After` methods. Is the name required to be `before`? (Granted,
the original name, `setup` wasn't very descriptive either.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
