rdblue commented on a change in pull request #201: Add appendManifest to
AppendFiles API.
URL: https://github.com/apache/incubator-iceberg/pull/201#discussion_r292131094
##########
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##########
@@ -69,16 +74,35 @@ public FastAppend appendFile(DataFile file) {
return this;
}
+ @Override
+ public FastAppend appendManifest(ManifestFile manifest) {
+ // the manifest must be rewritten with this update's snapshot ID
+ try (ManifestReader reader = ManifestReader.read(
+ ops.io().newInputFile(manifest.path()), ops.current()::spec)) {
+ appendManifests.add(ManifestWriter.copyAppendManifest(
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
