rdsr commented on a change in pull request #211: [Baseline] Apply baseline to
iceberg-orc #158
URL: https://github.com/apache/incubator-iceberg/pull/211#discussion_r292557198
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -164,14 +164,15 @@ private static Writer newOrcWriter(OutputFile file,
}
writer.addUserMetadata(COLUMN_NUMBERS_ATTRIBUTE, columnIds.serialize());
- metadata.forEach((key,value) -> writer.addUserMetadata(key,
ByteBuffer.wrap(value)));
+ metadata.forEach((key, value) -> writer.addUserMetadata(key,
ByteBuffer.wrap(value)));
return writer;
}
@SuppressWarnings("unchecked")
- private static <D> OrcValueWriter<D> newOrcValueWriter(TypeDescription
schema,
-
Function<TypeDescription, OrcValueWriter<?>> createWriterFunc) {
+ private static <D> OrcValueWriter<D> newOrcValueWriter(
+ TypeDescription schema,
+ Function<TypeDescription, OrcValueWriter<?>> createWriterFunc) {
Review comment:
Yes! I'll update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
