rdsr commented on a change in pull request #203: Support multiple partitions
derived from the same field
URL: https://github.com/apache/incubator-iceberg/pull/203#discussion_r293068656
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Projections.java
##########
@@ -205,20 +206,27 @@ private InclusiveProjection(PartitionSpec spec, boolean
caseSensitive) {
@Override
@SuppressWarnings("unchecked")
public <T> Expression predicate(BoundPredicate<T> pred) {
- PartitionField part = spec().getFieldBySourceId(pred.ref().fieldId());
- if (part == null) {
+ Collection<PartitionField> parts =
spec().getFieldsBySourceId(pred.ref().fieldId());
+ if (parts == null) {
Review comment:
Given how `org.apache.iceberg.PartitionSpec#fieldsBySourceId` field is
implemented . Parts will never be null, so this if block seems redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
