rdsr commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r296420626
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ColumnMap.java
##########
@@ -109,20 +154,27 @@ public ByteBuffer serialize() {
}
buffer.append(key.getId());
buffer.append(':');
- buffer.append(idMap.get(key).intValue());
+ buffer.append(idMap.get(key).getId());
+ buffer.append(':');
+ buffer.append(idMap.get(key).isRequired());
}
return ByteBuffer.wrap(buffer.toString().getBytes(StandardCharsets.UTF_8));
}
- public static ColumnIdMap deserialize(TypeDescription schema,
- ByteBuffer serial) {
- ColumnIdMap result = new ColumnIdMap();
+ static ColumnMap deserialize(TypeDescription schema,
+ ByteBuffer serial) {
Review comment:
nit: indentation error? Seems like ByteBuffer can be part of the same line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
