rdblue commented on issue #226: Apply Baseline plugin to iceberg-spark URL: https://github.com/apache/incubator-iceberg/pull/226#issuecomment-504787300 Here are some responses to the questions in the description. The rest of them sound fine to me. > Baseline applies ReturnChecker. Is it ok for us? Yes? What does it do? > Baseline doesn't apply ImportOrderChecker by default. Shall we add it? Yes, I think so. > Baseline doesn't apply DisallowSpaceBeforeTokenChecker by default. Shall we add it? I think so. This is consistent with the Java formatting, right? > Baseline doesn't apply NonASCIICharacterChecker by default. Shall we add it? Is this intended to catch fancy quotes? I think we probably don't need it. Plus, we have some areas with multi-byte characters in strings (@rdsr's recent Avro fix, for example).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
