edgarRd commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504867069 @rdblue @rdsr I agree to get this working before trying to fix ORC. I think as long as we agree on how to persist the schema in ORC files, since that'll go in the spec, we can change the implementation to something more maintainable later on avoiding the additional mapping class. I can follow up in the ORC project to get the metadata in fields. While we can store the JSON form of the Iceberg schema I think we'd still need the mapping of `ORC col -> Iceberg col`, right? Unless we have an assumption that the stored Iceberg schema maintains the column order of the ORC flatten columns, unless I'm missing something. Btw, thanks for taking a look at this!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
