electrum commented on a change in pull request #240: Add HiveCatalog
implementation
URL: https://github.com/apache/incubator-iceberg/pull/240#discussion_r298791717
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -134,10 +136,11 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
Integer.MAX_VALUE,
storageDescriptor(metadata),
Collections.emptyList(),
- new HashMap<>(),
+ Maps.newHashMap(),
null,
null,
- ICEBERG_TABLE_TYPE_VALUE);
+ TableType.EXTERNAL_TABLE.toString());
+ tbl.getParameters().put("EXTERNAL", "TRUE"); // using the external
table type also requires this
Review comment:
Who is responsible for cleaning up data in the Iceberg model? Is that out of
scope for the project (assumed that a complementary system handles it)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
