rdsr commented on a change in pull request #241: Use gradle-consistent-versions
to manage dependencies
URL: https://github.com/apache/incubator-iceberg/pull/241#discussion_r299174946
##########
File path: build.gradle
##########
@@ -253,24 +240,31 @@ project(':iceberg-hive') {
dependencies {
compile project(':iceberg-core')
- compileOnly "org.apache.avro:avro:$avroVersion"
+ compileOnly "org.apache.avro:avro"
- compileOnly("org.apache.hive:hive-metastore:$hiveVersion") {
+ compileOnly("org.apache.hive:hive-metastore") {
exclude group: 'org.apache.avro', module: 'avro'
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ exclude group: 'org.pentaho' // missing dependency
}
// By default, hive-exec is a fat/uber jar and it exports a guava library
// that's really old. We use the core classifier to be able to override
our guava
// version. Luckily, hive-exec seems to work okay so far with this version
of guava
// See: https://github.com/apache/hive/blob/master/ql/pom.xml#L911 for
more context.
- testCompile("org.apache.hive:hive-exec:$hiveVersion:core") {
+ testCompile("org.apache.hive:hive-exec::core") {
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ exclude group: 'org.pentaho' // missing dependency
Review comment:
What does a missing dependency here imply?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
