mccheah commented on a change in pull request #241: Use gradle-consistent-versions to manage dependencies URL: https://github.com/apache/incubator-iceberg/pull/241#discussion_r301340761
########## File path: versions.props ########## @@ -0,0 +1,19 @@ +org.slf4j:slf4j-api = 1.7.5 +com.google.guava:guava = 28.0-jre +org.apache.avro:avro = 1.8.2 +org.apache.hadoop:* = 2.7.3 +org.apache.hive:hive-standalone-metastore = 1.2.1 +org.apache.orc:orc-core = 1.5.5 +org.apache.parquet:parquet-avro = 1.10.0 +org.apache.spark:spark-hive_2.11 = 2.4.0 +org.apache.pig:pig = 0.14.0 +com.fasterxml.jackson.*:* = 2.7.9 Review comment: Well Spark upstream is pushing the Jackson version up to 2.9.9: https://github.com/apache/spark/blob/master/pom.xml#L173. Meanwhile we don't hit this because we don't use shadow jars instead of using mega-shadow-jars for most things. We also bumped Jackson in our fork: https://github.com/palantir/spark/blob/master/pom.xml#L182 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
