vrozov commented on issue #272: Refactor AvroIterable and prevent multiple 
iterators
URL: https://github.com/apache/incubator-iceberg/pull/272#issuecomment-509834627
 
 
   There is no such assumption in `org.apache.avro.file.DataFileReader` and 
there is no such expectation in the existing iceberg code. Ability to get 
multiple iterators from `AvroIterable` will promote code that leads to 
performance degradation: `AvroIterable` iterator does file I/O, iterating twice 
like in the code example I provided, should be discouraged in favor of a single 
iteration over avro file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to