rdblue commented on issue #271: Remove iceberg-presto-runtime that is no longer used. URL: https://github.com/apache/incubator-iceberg/pull/271#issuecomment-511026249 @vrozov, good to know about the HiveMetaStoreClient constructor. We can update the constructor call to work in both 1.2.1 and 3.x variants. Sounds like the justification for Guava is that this could happen with that library as well. I agree with that, and we can either avoid calls that are problematic or use reflection for shims. Either way, I'm not sure that it is necessary to create a shaded Presto runtime library. On #256, I asked whether Presto actually used this and the answer was no. If Presto needs one, we can add it back. Otherwise, I think we should publish normal dependencies and let Presto handle their transitive dependencies. If there is a problem, we are flexible and can work with that community to fix it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
