moulimukherjee commented on a change in pull request #283: WIP: Add
projectStrict for Dates and Timestamps
URL: https://github.com/apache/incubator-iceberg/pull/283#discussion_r303217879
##########
File path: api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java
##########
@@ -52,6 +52,23 @@ private ProjectionUtil() {}
}
}
+ static <T> UnboundPredicate<Integer> truncateStrictToInteger(
+ String name, BoundPredicate<T> pred, Transform<T, Integer> transform) {
+ T boundary = pred.literal().value();
+ switch (pred.op()) {
+ case LT:
+ case LT_EQ:
+ return predicate(Expression.Operation.LT_EQ, name,
transform.apply(boundary) - 1);
Review comment:
Subtracting 1 after transforming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
