rdblue commented on a change in pull request #285: Update metadata tables for
unpartitioned tables
URL: https://github.com/apache/incubator-iceberg/pull/285#discussion_r304003811
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -66,23 +74,26 @@ public String location() {
public static class FilesTableScan extends BaseTableScan {
private static final long TARGET_SPLIT_SIZE = 32 * 1024 * 1024; // 32 MB
+ private final Schema fileSchema;
Review comment:
Right now, data tasks aren't responsible for projection because that's done
easily by the engines. So we don't want to use the refined schema.
We could use the base table's schema without passing it through by making
this a non-static inner class, but doing that seems odd with the refinement
pattern to me. I thought it would be better to explicitly pass this through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
