danielcweeks commented on a change in pull request #277: Moving/Renaming hadoop
module to filesystem
URL: https://github.com/apache/incubator-iceberg/pull/277#discussion_r304522280
##########
File path: python/iceberg/core/filesystem/util.py
##########
@@ -33,21 +31,8 @@ def get_fs(path, conf, local_only=False):
if parsed_path.scheme in ["", "file"]:
return LocalFileSystem.get_instance()
elif parsed_path.scheme in ["s3", "s3n"]:
- if conf.get("hive.aws_iam_role") is not None:
- key, secret, token =
get_sts_session_keys(conf.get("hive.aws_iam_role"))
- return S3FileSystemWrapper(key=key, secret=secret, token=token)
- return S3FileSystemWrapper()
+ return S3FileSystemWrapper(conf=conf)
Review comment:
Looks like we are returning a new instance of the s3 filesystem for each
call, but using a shared instance for local file system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
