rdsr commented on a change in pull request #292: Fix specForTable in case of
unpartitioned table
URL: https://github.com/apache/incubator-iceberg/pull/292#discussion_r304683784
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkSchemaUtil.java
##########
@@ -70,17 +70,18 @@ public static Schema schemaForTable(SparkSession spark,
String name) {
*
* @param spark a Spark session
* @param name a table name and (optional) database
- * @return a PartitionSpec for the table, if found
+ * @return a PartitionSpec for the table
* @throws AnalysisException if thrown by the Spark catalog
*/
public static PartitionSpec specForTable(SparkSession spark, String name)
throws AnalysisException {
Review comment:
OK. Also a minor point but, do you think this change was more suitable in
the `identitySpec` method which is defined as
```
private static PartitionSpec identitySpec(Schema schema, List<String>
partitionNames) {
if (partitionNames == null || partitionNames.isEmpty()) {
return null;
}
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
