moulimukherjee commented on a change in pull request #283: Add projectStrict
for Dates and Timestamps
URL: https://github.com/apache/incubator-iceberg/pull/283#discussion_r307898308
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Projections.java
##########
@@ -221,9 +221,10 @@ private InclusiveProjection(PartitionSpec spec, boolean
caseSensitive) {
// similarly, if partitioning by day(ts) and hour(ts), the more
restrictive
// projection should be used. ts = 2019-01-01T01:00:00 produces
day=2019-01-01 and
// hour=2019-01-01-01. the value will be in 2019-01-01-01 and not in
2019-01-01-02.
- result = Expressions.and(
- result,
- ((Transform<T, ?>) part.transform()).project(part.name(), pred));
+ UnboundPredicate<?> inclusiveProjection = ((Transform<T, ?>)
part.transform()).project(part.name(), pred);
+ if (inclusiveProjection != null) {
Review comment:
added null check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
