danielcweeks commented on a change in pull request #277: Moving/Renaming hadoop
module to filesystem
URL: https://github.com/apache/incubator-iceberg/pull/277#discussion_r309471740
##########
File path: python/iceberg/core/filesystem/util.py
##########
@@ -33,21 +31,8 @@ def get_fs(path, conf, local_only=False):
if parsed_path.scheme in ["", "file"]:
return LocalFileSystem.get_instance()
elif parsed_path.scheme in ["s3", "s3n"]:
Review comment:
Looks like we're still missing `s3a` here. You might want to just delegate
this to `S3FileSystem.is_s3(...)` or similar, so we can keep all checks for
various fs schemes together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
