SurenNihalani commented on a change in pull request #236: iceberg: don't bundle
hdfs with iceberg runtime
URL: https://github.com/apache/incubator-iceberg/pull/236#discussion_r309523300
##########
File path: build.gradle
##########
@@ -431,7 +431,7 @@ project(':iceberg-spark-runtime') {
relocate 'org.apache.orc', 'org.apache.iceberg.shaded.org.apache.orc'
relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
- archiveName = "iceberg-spark-runtime-${version}.${extension}"
+ archiveBaseName = "iceberg-spark-runtime"
Review comment:
This maintains compatibility for future gradle upgrades because archiveName
is deprecated. see:
https://docs.gradle.org/current/dsl/org.gradle.api.tasks.bundling.Jar.html#org.gradle.api.tasks.bundling.Jar:archiveName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
