aokolnychyi commented on a change in pull request #351: Provide an API to 
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310801433
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
 ##########
 @@ -158,6 +158,16 @@ public OverwriteFiles newOverwrite() {
     return overwrite;
   }
 
+  @Override
+  public ModifyFiles newModify() {
+    checkLastOperationCommitted("ModifyFiles");
+    Long baseSnapshotId = currentId(base);
 
 Review comment:
   I am using the base snapshot id of the transaction here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to