rdblue commented on a change in pull request #357: Jun/in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r311676526
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java
##########
@@ -105,6 +105,16 @@ public static Expression not(Expression child) {
return new UnboundPredicate<>(Expression.Operation.NOT_EQ, ref(name),
value);
}
+ public static <T> UnboundPredicate<T> in(String name, T value, T... values) {
+ Preconditions.checkNotNull(value, "in predicate must include at least one
value");
Review comment:
All of the values should be non-null. Null values can only be selected with
`isNull`. To select from a set or a null value, the predicate must be
`or(isNull(t), in(t, 1, 2, 3))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
