aokolnychyi commented on a change in pull request #362: Support create and 
replace transactions in Catalog
URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r311696942
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -97,6 +98,42 @@ default Table createTable(
     return createTable(identifier, schema, PartitionSpec.unpartitioned(), 
null, null);
   }
 
+  /**
+   * Start a transaction to create a table.
+   *
+   * @param identifier a table identifier
+   * @param schema a schema
+   * @param spec a partition spec
+   * @param location a location for the table; leave null if unspecified
+   * @param properties a string map of table properties
+   * @return a {@link Transaction} to create the table
+   * @throws AlreadyExistsException if the table already exists
+   */
+  Transaction newCreateTableTransaction(
 
 Review comment:
   I am a bit concerned about the number of methods we will have in `Catalog`. 
So, I did not include overloaded helper methods as we have for create table 
statements. Let me know what other people think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to