rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r312223092
########## File path: core/src/test/java/org/apache/iceberg/TestMetrics.java ########## @@ -72,23 +78,14 @@ public abstract File writeRecords(Schema schema, Record... records) throws IOException; + public abstract File writeRecords(Schema schema, Map<String, String> properties, GenericData.Record... records) + throws IOException; + + public abstract int getRowGroupSize(File parquetFile) throws IOException; Review comment: I think this is actually row group count, right? In that case, I think this should be named with "count" instead of "size". Also, this is a generic metrics test so this should not be specific to Parquet. How about `splitCount(File dataFile)` instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
