jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315009996
########## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ########## @@ -89,12 +93,12 @@ public R or(R leftResult, R rightResult) { return null; } - public <T> R in(BoundReference<T> ref, Literal<T> lit) { - return null; + public <T> R in(BoundReference<T> ref, LiteralSet<T> literalSet) { Review comment: As only `BoundSetPredicate` can access `LiteralSet`, I will make `LiteralSet` as `BoundSetPredicate`'s private inner class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org