aokolnychyi commented on a change in pull request #351: Extend Iceberg with a
way to overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317398734
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -88,6 +119,42 @@ public OverwriteFiles validateAddedFiles() {
}
}
+ if (conflictDetectionFilter != null) {
+ PartitionSpec spec = writeSpec();
+ Expression inclusiveExpr =
Projections.inclusive(spec).project(conflictDetectionFilter);
+ Evaluator inclusive = new Evaluator(spec.partitionType(), inclusiveExpr);
+
+ InclusiveMetricsEvaluator metrics = new
InclusiveMetricsEvaluator(base.schema(), conflictDetectionFilter);
+
+ List<DataFile> newFiles = collectNewFiles(base);
+ for (DataFile newFile : newFiles) {
+ ValidationException.check(
+ !inclusive.eval(newFile.partition()) || !metrics.eval(newFile),
+ "A conflicting file was appended that matches filter '%s': %s",
Review comment:
You are right, that's exactly the behavior we wanted to achieve. If the file
can potentially contain data that matches the filter, we should fail. I should
update the error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
