manishmalhotrawork commented on issue #280: Add persistent IDs to partition fields URL: https://github.com/apache/incubator-iceberg/issues/280#issuecomment-525415789 @rdblue thanks. Let me take a stab on this, may be as you mentioned in description. Passing initial value for the partitionId to PartitionSpec from TableMetadata. And also as TableMetadata knows how many fields are in partition, so can maintain the nextIDValue as well. So, that when `PartitionSpec.partitionType` will be called, it will use the passed value as first ID and then increment. Also the [TableMetadata#updatePartitionSpec](https://github.com/apache/incubator-iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableMetadata.java#L294) should also use nextIDValue to pass to PartitionSpec. Does modifying/dropping columns also needs to be taken care, I believe not? yeah, for my understanding, a sample partitioned table manifest file's schema has this entry for partition. Where field-id is 1000+. ``` "name" : "partition", "type" : { "type" : "record", "name" : "r102", "fields" : [ { "name" : "order_status", "type" : [ "null", "string" ], "default" : null, "field-id" : 1000 }, { "name" : "ship_priority", "type" : [ "null", "int" ], "default" : null, "field-id" : 1001 }, { "name" : "order_key_bucket", "type" : [ "null", "int" ], "default" : null, "field-id" : 1002 } ]```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
