rdblue commented on a change in pull request #374: Migrate spark table to
iceberg table
URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318684701
##########
File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala
##########
@@ -131,18 +136,22 @@ object SparkTableUtil {
s"$name=${partition(name)}"
}.mkString("/")
- DataFiles.builder(spec)
- .withPath(path)
- .withFormat(format)
- .withPartitionPath(partitionKey)
- .withFileSizeInBytes(fileSize)
- .withMetrics(new Metrics(rowCount,
- arrayToMap(columnSizes),
- arrayToMap(valueCounts),
- arrayToMap(nullValueCounts),
- arrayToMap(lowerBounds),
- arrayToMap(upperBounds)))
- .build()
+ var builder = DataFiles.builder(spec)
+ .withPath(path)
+ .withFormat(format)
+ .withFileSizeInBytes(fileSize)
+ .withMetrics(new Metrics(rowCount,
+ arrayToMap(columnSizes),
+ arrayToMap(valueCounts),
+ arrayToMap(nullValueCounts),
+ arrayToMap(lowerBounds),
+ arrayToMap(upperBounds)))
+
+ if (partitionKey == "") {
+ builder.build()
+ } else {
+ builder.withPartitionPath(partitionKey).build()
Review comment:
Yeah, that looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
