rdsr commented on a change in pull request #421: Add friendly names to catalog
tables
URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r318886702
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -43,6 +43,11 @@ public HiveCatalog(Configuration conf) {
this.conf = conf;
}
+ @Override
+ protected String name() {
+ return conf.get("hive.metastore.uris");
Review comment:
There are usually multiple Metastore deployments, per cluster, so would
passing a name in the constructor correctly identify those. I'm guessing a
name would be hard coded. Or would it come from conf/hiveconf?
`hive.metastore.uris` does uniquely identify cluster specific Metastores.
If it is simpler to keep `hive.metastore.uris` then I'm all for it.
Also can `hive.metastore.uris` be null in local/embedded mode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
