rdblue commented on issue #429: Remove the private field of "name" from Dates and Timestamps URL: https://github.com/apache/incubator-iceberg/issues/429#issuecomment-526677751 I understand what you intend here, but I don't think there is much value to making this change. The memory required is negligible and I think it is more explicit to use a name field instead of relying on behavior of some third-party class that is not guaranteed. Iceberg shouldn't depend on ChronoUnit's toString to write its metadata correctly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
