rdblue commented on a change in pull request #443: Add null check in GenericRecord#get method to avoid failure when value is null URL: https://github.com/apache/incubator-iceberg/pull/443#discussion_r321353291
########## File path: data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.data; + +import org.apache.iceberg.Schema; +import org.apache.iceberg.types.Types; +import org.junit.Assert; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.apache.iceberg.types.Types.NestedField.optional; + +public class TestGenericRecord { + + @Rule + public ExpectedException thrown = ExpectedException.none(); + + @Test + public void testGetNullValue() { + Types.LongType type = Types.LongType.get(); + Schema schema = new Schema(optional(1, "id", type)); + GenericRecord record = GenericRecord.create(schema); + record.set(0, null); + + Assert.assertNull(record.get(0, type.typeId().javaClass())); + } + + @Test + public void testGetNotNullValue() { + Types.LongType type = Types.LongType.get(); + Schema schema = new Schema(optional(1, "id", type)); + GenericRecord record = GenericRecord.create(schema); + record.set(0, 10L); + + Assert.assertEquals(10L, record.get(0, type.typeId().javaClass())); + } + + @Test + public void testGetIncorrectClassInstance() { + Schema schema = new Schema(optional(1, "id", Types.LongType.get())); + GenericRecord record = GenericRecord.create(schema); + record.set(0, 10L); + + thrown.expect(IllegalStateException.class); + record.get(0, CharSequence.class); Review comment: Usually, we want to use the `assertThrows` method from test helpers instead of using the `ExpectedException` rule. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
