waterlx commented on a change in pull request #447: Update doc to state that
day partition transform produces data type
URL: https://github.com/apache/incubator-iceberg/pull/447#discussion_r321540316
##########
File path: site/docs/spec.md
##########
@@ -139,7 +139,7 @@ Partition specs capture the transform from table data to
partition values. This
| **`truncate[W]`** | Value truncated to width `W` (see below)
| `int`, `long`, `decimal`, `string`
| Source type |
| **`year`** | Extract a date or timestamp year, as years from 1970
| `date`, `timestamp(tz)`
| `int` |
| **`month`** | Extract a date or timestamp month, as months from
1970-01-01 | `date`, `timestamp(tz)`
| `int` |
-| **`day`** | Extract a date or timestamp day, as days from 1970-01-01
| `date`, `timestamp(tz)`
| `int` |
+| **`day`** | Extract a date or timestamp day, as date
| `date`, `timestamp(tz)`
| `date` |
Review comment:
@rdblue Comment addressed, Only "Return type" is changed. Please review at
your most convenience, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
