vvysotskyi commented on issue #442: Optimize ExpressionVisitors.visit method to traverse minimum nodes number required for determining the result URL: https://github.com/apache/incubator-iceberg/pull/442#issuecomment-528939041 @rdblue, thanks for code review and your suggestions, I have made requested changes. I have replaced usage of the existing method `visit()` with the new `visitEvaluator()` method for `Boolean` visitors. I've also thought about the way, how we can optimize it for `Expression` visitors, since some of them may use `True.INSTANCE` and `False.INSTANCE` expressions. It is possible to add methods which accept suppliers into `ExpressionVisitor` and override these methods with short-circuit logic in some implementations where it will not cause issues, what do you think about this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org