rdblue commented on issue #442: Optimize ExpressionVisitors.visit method to traverse minimum nodes number required for determining the result URL: https://github.com/apache/incubator-iceberg/pull/442#issuecomment-528997506 > I've also thought about the way, how we can optimize it for Expression visitors, since some of them may use True.INSTANCE and False.INSTANCE expressions. It is possible to add methods which accept suppliers into ExpressionVisitor and override these methods with short-circuit logic in some implementations where it will not cause issues, what do you think about this? If there are others that would benefit, I think we should add a new visit method for this that checks for `True.INSTANCE` and `False.INSTANCE`. That can be used for visitors that support short-circuit evaluation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
