rdblue commented on a change in pull request #456: Fix avro data test schema
according to spec
URL: https://github.com/apache/incubator-iceberg/pull/456#discussion_r321894718
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -120,6 +121,17 @@ public static Schema assignFreshIds(Schema schema, NextID
nextId) {
.fields());
}
+ /**
+ * Assigns strictly increasing fresh ids for all fields in a schema,
starting from 0.
Review comment:
When a new ID is created, the IDs are assigned starting from 1. Can you
update this to do the same to avoid confusion later on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
